Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel
Commit Hook
null at kde.org
Fri Aug 2 10:16:25 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111833/#review36963
-----------------------------------------------------------
This review has been submitted with commit 09eecac88cc1c3e7bd525ec8c2eb50be30bfec1c by Aleix Pol to branch frameworks.
- Commit Hook
On Aug. 1, 2013, 11:03 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111833/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 11:03 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Directly read the config instead of using KGlobalSettings as a proxy for the setting.
>
> We lose the setting changed functionality but now we don't depend on KGlobalSettings class.
>
> There's KDE_DEFAULT_* but I'll see how to do that in a different patch, there are other cases where it's needed.
>
>
> Diffs
> -----
>
> KDE5PORTING.html 9d84525
> kfile/kdirsortfilterproxymodel.cpp c8ea9b2
>
> Diff: http://git.reviewboard.kde.org/r/111833/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130802/2ae85317/attachment.html>
More information about the Kde-frameworks-devel
mailing list