Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel
Commit Hook
null at kde.org
Fri Aug 2 10:16:30 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111833/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 10:16 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Description
-------
Directly read the config instead of using KGlobalSettings as a proxy for the setting.
We lose the setting changed functionality but now we don't depend on KGlobalSettings class.
There's KDE_DEFAULT_* but I'll see how to do that in a different patch, there are other cases where it's needed.
Diffs
-----
KDE5PORTING.html 9d84525
kfile/kdirsortfilterproxymodel.cpp c8ea9b2
Diff: http://git.reviewboard.kde.org/r/111833/diff/
Testing
-------
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130802/a4cd206f/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list