Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111833/#review36955
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Aug. 1, 2013, 11:03 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111833/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 11:03 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Directly read the config instead of using KGlobalSettings as a proxy for the setting.
> 
> We lose the setting changed functionality but now we don't depend on KGlobalSettings class.
> 
> There's KDE_DEFAULT_* but I'll see how to do that in a different patch, there are other cases where it's needed.
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html 9d84525 
>   kfile/kdirsortfilterproxymodel.cpp c8ea9b2 
> 
> Diff: http://git.reviewboard.kde.org/r/111833/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130802/b408568c/attachment-0001.html>