Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Aug 1 11:03:19 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111833/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 11:03 a.m.)
Review request for KDE Frameworks.
Changes
-------
Add porting notes.
Description
-------
Directly read the config instead of using KGlobalSettings as a proxy for the setting.
We lose the setting changed functionality but now we don't depend on KGlobalSettings class.
There's KDE_DEFAULT_* but I'll see how to do that in a different patch, there are other cases where it's needed.
Diffs (updated)
-----
KDE5PORTING.html 9d84525
kfile/kdirsortfilterproxymodel.cpp c8ea9b2
Diff: http://git.reviewboard.kde.org/r/111833/diff/
Testing
-------
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130801/e8624319/attachment.html>
More information about the Kde-frameworks-devel
mailing list