Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel

Aleix Pol Gonzalez aleixpol at kde.org
Thu Aug 1 10:53:01 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111833/
-----------------------------------------------------------

Review request for KDE Frameworks.


Summary (updated)
-----------------

Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel


Description (updated)
-------

Directly read the config instead of using KGlobalSettings as a proxy for the setting.

We lose the setting changed functionality but now we don't depend on KGlobalSettings class.

There's KDE_DEFAULT_* but I'll see how to do that in a different patch, there are other cases where it's needed.


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/111833/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130801/4f328ff7/attachment.html>


More information about the Kde-frameworks-devel mailing list