Review Request: Port some uses of KUrl to QUrl
Kevin Funk
krf at gmx.de
Wed Sep 19 22:19:20 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106501/
-----------------------------------------------------------
(Updated Sept. 19, 2012, 10:19 p.m.)
Review request for KDE Frameworks.
Changes
-------
Good catch. Restored the old behaviour, using str.replace("/bin/sh/", m_sh). m_sh is initialized to findExecutable("sh").
Description
-------
Port some uses of KUrl to QUrl
kio: Cleanup header a bit
kio: Merge some functions using default arguments
kio: Mark test with QSKIP_PORTING
Diffs (updated)
-----
kio/kio/krun.h 7bfe66b59f1deffc37d3ceae999fb929e453fd31
kio/kio/krun.cpp 031dbc1dfef685729038b4a59cbeacd34d448ed2
kio/tests/kruntest.h 6f5eae6147e2fbef25025976a17869af4d0f12f9
kio/tests/kruntest.cpp 92496bd1d4b98ea8f7dc13977cd3d2aa0dae7145
kio/tests/krununittest.cpp 314da79b9ee4f95bcc9f768a95810f7de3125ac1
Diff: http://git.reviewboard.kde.org/r/106501/diff/
Testing
-------
Thanks,
Kevin Funk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120919/1e0cb0a2/attachment.html>
More information about the Kde-frameworks-devel
mailing list