Review Request: Port some uses of KUrl to QUrl

Oswald Buddenhagen ossi at kde.org
Thu Sep 20 21:34:17 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106501/#review19241
-----------------------------------------------------------



kio/tests/krununittest.cpp
<http://git.reviewboard.kde.org/r/106501/#comment15262>

    this whole hunk doesn't belong into this patch at all. one part of it belongs into the kprocess patch, the other (the kdesuExe part) is a commit of its own.


- Oswald Buddenhagen


On Sept. 19, 2012, 10:19 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106501/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 10:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port some uses of KUrl to QUrl
> 
> 
> kio: Cleanup header a bit
> 
> 
> kio: Merge some functions using default arguments
> 
> 
> kio: Mark test with QSKIP_PORTING
> 
> 
> Diffs
> -----
> 
>   kio/kio/krun.h 7bfe66b59f1deffc37d3ceae999fb929e453fd31 
>   kio/kio/krun.cpp 031dbc1dfef685729038b4a59cbeacd34d448ed2 
>   kio/tests/kruntest.h 6f5eae6147e2fbef25025976a17869af4d0f12f9 
>   kio/tests/kruntest.cpp 92496bd1d4b98ea8f7dc13977cd3d2aa0dae7145 
>   kio/tests/krununittest.cpp 314da79b9ee4f95bcc9f768a95810f7de3125ac1 
> 
> Diff: http://git.reviewboard.kde.org/r/106501/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120920/d941d9ff/attachment.html>


More information about the Kde-frameworks-devel mailing list