Review Request: Port some uses of KUrl to QUrl

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106501/#review19175
-----------------------------------------------------------


Looks ok. Might break krununittest on systems with 'sh' elsewhere than /bin/sh though, since you removed that code. Did you check git log for details? Maybe we can locate sh differently, e.g. with findExecutable. I don't remember the details.

- David Faure


On Sept. 18, 2012, 11:15 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106501/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2012, 11:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port some uses of KUrl to QUrl
> 
> 
> kio: Cleanup header a bit
> 
> 
> kio: Merge some functions using default arguments
> 
> 
> kio: Mark test with QSKIP_PORTING
> 
> 
> Diffs
> -----
> 
>   kio/kio/krun.h 7bfe66b59f1deffc37d3ceae999fb929e453fd31 
>   kio/kio/krun.cpp 031dbc1dfef685729038b4a59cbeacd34d448ed2 
>   kio/tests/kruntest.h 6f5eae6147e2fbef25025976a17869af4d0f12f9 
>   kio/tests/kruntest.cpp 92496bd1d4b98ea8f7dc13977cd3d2aa0dae7145 
>   kio/tests/krununittest.cpp 314da79b9ee4f95bcc9f768a95810f7de3125ac1 
> 
> Diff: http://git.reviewboard.kde.org/r/106501/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120919/f730e931/attachment.html>