<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106501/">http://git.reviewboard.kde.org/r/106501/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks ok. Might break krununittest on systems with 'sh' elsewhere than /bin/sh though, since you removed that code. Did you check git log for details? Maybe we can locate sh differently, e.g. with findExecutable. I don't remember the details.</pre>
<br />
<p>- David</p>
<br />
<p>On September 18th, 2012, 11:15 p.m., Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2012, 11:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port some uses of KUrl to QUrl
kio: Cleanup header a bit
kio: Merge some functions using default arguments
kio: Mark test with QSKIP_PORTING</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/krun.h <span style="color: grey">(7bfe66b59f1deffc37d3ceae999fb929e453fd31)</span></li>
<li>kio/kio/krun.cpp <span style="color: grey">(031dbc1dfef685729038b4a59cbeacd34d448ed2)</span></li>
<li>kio/tests/kruntest.h <span style="color: grey">(6f5eae6147e2fbef25025976a17869af4d0f12f9)</span></li>
<li>kio/tests/kruntest.cpp <span style="color: grey">(92496bd1d4b98ea8f7dc13977cd3d2aa0dae7145)</span></li>
<li>kio/tests/krununittest.cpp <span style="color: grey">(314da79b9ee4f95bcc9f768a95810f7de3125ac1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106501/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>