Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

[Jon Severinsson]

> On Oct. 23, 2012, 10:09 a.m., David Faure wrote:
> > Too hackish ;-) Please add #cmakedefine01 HAVE_X11 config-plasma.h and ensure it's set, like it's done in other subdirs.

It already is, that is not the problem.

The problem is that for this file, and this file only, the X11 specific parts can not be used on Qt5, even when HAVE_X11 is set to 1.
The only solutions is to set HAVE_X11 to 0 on Qt5, or replace all six occurances of "#if HAVE_X11" with "#if HAVE_X11 && QT_VERSION < QT_VERSION_CHECK(5, 0, 0)".


- Jon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106989/#review20730
-----------------------------------------------------------


On Oct. 22, 2012, 4:26 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106989/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2012, 4:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This essentially makes WindowShadows a no-op, but it is better than not compiling...
> 
> The issue is currently hidden by Plasma not being built at all on Qt5, but this should be fixed before my "Drop KDE_NO_PHONON hackery from KDE Frameworks" patch are merged, or Qt5 compilation will break.
> 
> 
> Diffs
> -----
> 
>   plasma/private/windowshadows.cpp 645dddd 
> 
> Diff: http://git.reviewboard.kde.org/r/106989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121023/09db084f/attachment.html>