Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106989/#review20730
-----------------------------------------------------------


Too hackish ;-) Please add #cmakedefine01 HAVE_X11 config-plasma.h and ensure it's set, like it's done in other subdirs.

- David Faure


On Oct. 22, 2012, 4:26 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106989/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2012, 4:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This essentially makes WindowShadows a no-op, but it is better than not compiling...
> 
> The issue is currently hidden by Plasma not being built at all on Qt5, but this should be fixed before my "Drop KDE_NO_PHONON hackery from KDE Frameworks" patch are merged, or Qt5 compilation will break.
> 
> 
> Diffs
> -----
> 
>   plasma/private/windowshadows.cpp 645dddd 
> 
> Diff: http://git.reviewboard.kde.org/r/106989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121023/6d0c6fd8/attachment-0001.html>