<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106989/">http://git.reviewboard.kde.org/r/106989/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 23rd, 2012, 10:09 a.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Too hackish ;-) Please add #cmakedefine01 HAVE_X11 config-plasma.h and ensure it's set, like it's done in other subdirs.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It already is, that is not the problem.
The problem is that for this file, and this file only, the X11 specific parts can not be used on Qt5, even when HAVE_X11 is set to 1.
The only solutions is to set HAVE_X11 to 0 on Qt5, or replace all six occurances of "#if HAVE_X11" with "#if HAVE_X11 && QT_VERSION < QT_VERSION_CHECK(5, 0, 0)".</pre>
<br />
<p>- Jon</p>
<br />
<p>On October 22nd, 2012, 4:26 p.m., Jon Severinsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2012, 4:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This essentially makes WindowShadows a no-op, but it is better than not compiling...
The issue is currently hidden by Plasma not being built at all on Qt5, but this should be fixed before my "Drop KDE_NO_PHONON hackery from KDE Frameworks" patch are merged, or Qt5 compilation will break.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/private/windowshadows.cpp <span style="color: grey">(645dddd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106989/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>