Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

Jon Severinsson jon at severinsson.net
Mon Oct 22 16:26:24 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106989/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

This essentially makes WindowShadows a no-op, but it is better than not compiling...

The issue is currently hidden by Plasma not being built at all on Qt5, but this should be fixed before my "Drop KDE_NO_PHONON hackery from KDE Frameworks" patch are merged, or Qt5 compilation will break.


Diffs
-----

  plasma/private/windowshadows.cpp 645dddd 

Diff: http://git.reviewboard.kde.org/r/106989/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121022/83d05799/attachment.html>


More information about the Kde-frameworks-devel mailing list