Review Request: Drop KDE_NO_PHONON hackery from KDE Frameworks

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106987/#review20728
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Oct. 22, 2012, 4:17 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106987/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2012, 4:17 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> With the patches I have already submitted to review board it is now possible to build Phonon five on Qt5. There is thus no longer any reason to drop phonon-dependent parts of KF5 from being built on Qt5.
> 
> I will obviously not push this patch until after all requisite Phonon five patches have been pushed.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0ce6cdf 
>   interfaces/CMakeLists.txt d496d01 
>   knotify/config/knotifyconfigactionswidget.cpp de892fe 
> 
> Diff: http://git.reviewboard.kde.org/r/106987/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121023/cbd26d89/attachment.html>