Definition of done - warning

[Stephen Kelly]

Benjamin Port wrote:

> Currently when we build kdelibs there are lots of warnings. That's why I
> suggest to add a remove all warnings in the definition of done.
> 
> But we can't remove all warnings, indeed some warnings come from moc file
> (deprecated slots) and from unit test where we want to test the behavior
> of deprecated method.
> 
> For the first one I don't have any idea to manage that (and I think there
> is no solution)
> For unit test we can add to gcc the -Wno-deprecated-declarations option.
> Perhaps we can do that by adding a test macro defined in ecm.
> 
> So I suggest to have the following definition of done:
> "Remove all warning except in moc files (deprecated slot)"
> 
> Yes that is lot of work but I think if we manage to do that, in the future
> we can easely continu to have a warningless code.

If the slots are already deprecated in kdelibs4 then they should be removed 
in frameworks, unless there is a good reason to keep them.

Thanks,

Steve.