Review Request: Make kcodecs framework build standalone

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105860/
-----------------------------------------------------------

(Updated Aug. 5, 2012, 9:22 a.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

(Changing review group to "kdeframeworks").

Please port kcharsets.cpp away from I18N_NOOP2, instead, using QT_TRANSLATE_NOOP3 and QCoreApplication::translate, both with an empty "context" (for compatibility with gettext).

The idea of a tier1 framework is that it only depends on Qt, not on other tier1 frameworks.

Thanks for joining the frameworks effort, much appreciated!


Description
-------

Make it possible to build kcodecs independently of the whole kdelibs-frameworks tree.


Diffs
-----

  tier1/kcodecs/CMakeLists.txt 22463ca0345e6d50384c17bf5f43824e3445b55f 

Diff: http://git.reviewboard.kde.org/r/105860/diff/


Testing
-------

Works for me, both standalone and as part of kdelibs


Thanks,

George Goldberg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120805/6e5ced08/attachment.html>