Review Request: Make kcodecs framework build standalone

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105860/
-----------------------------------------------------------

(Updated Aug. 5, 2012, 2:24 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Port to Qt translations.  I couldn't just 1-for-1 replace K18N_NOOP2 with QT_TRANSLATE_NOOP3 so I came up with the solution in this patch instead.  I'm not very experienced with the localisation stuff, so please shout if there is a better way of doing it.  This patch removes the last kdelibs dependency for the kcodecs framework.  The modified generator script will appear in a subsequent review request against kdesdk.


Description
-------

Make it possible to build kcodecs independently of the whole kdelibs-frameworks tree.


Diffs (updated)
-----

  tier1/kcodecs/CMakeLists.txt 22463ca0345e6d50384c17bf5f43824e3445b55f 
  tier1/kcodecs/src/kcharsets.cpp c64aa12361583cd9184bc39495c7149e6b0d7796 
  tier1/kcodecs/src/kencodingprober.cpp 1dad3272986c2b0c693cd1bbf49fd40055300e39 

Diff: http://git.reviewboard.kde.org/r/105860/diff/


Testing
-------

Works for me, both standalone and as part of kdelibs


Thanks,

George Goldberg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120805/b9565124/attachment-0001.html>