Review Request: KF5 - Q_OS_* not defined

Andrius da Costa Ribas andriusmao at gmail.com
Sun Aug 5 22:28:06 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105868/
-----------------------------------------------------------

(Updated Aug. 5, 2012, 10:28 p.m.)


Review request for KDE Frameworks and kdewin.


Changes
-------

Oops ... last one had something wrong.


Description
-------

Q_OS_WIN & Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE.


Diffs (updated)
-----

  kde3support/KDE3SupportMacros.cmake a4f44e2 
  kdecore/CMakeLists.txt e5cbd19 
  kded/CMakeLists.txt fb204e8 
  kdeui/CMakeLists.txt 7849b52 
  kdeui/KDEUIMacros.cmake d5c20d9 
  kinit/CMakeLists.txt 3c283a6 
  tier1/kidletime/src/CMakeLists.txt 973d623 
  tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd 

Diff: http://git.reviewboard.kde.org/r/105868/diff/


Testing
-------

Got undefined references before the fix.


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120805/e44abb52/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list