[Kde-finance-apps] Re: problem while committing

[Thomas Baumgart]

Hi,

on Sunday 10 July 2011 11:42:00 puneet goyal wrote:

> Thanks a lot Sir,
> I was not checking out from the working copy which needed to be checked out
> using svn+ssh protocol
> I have uploaded 4 of the files in playground/office/alkimia/payment
> I will be making other files which i think would be useful in the mean
> while, please let me know where I should procede noe.


A few comments:


- I think I mentioned the missing license issue already.

- I ran astyle which formatted some code. Please update your sandbox from svn 
to get those changes in formatting.

- Please add more description to the alkuser object. What is is good for and 
what's its purpose? I am not sure what the attributes should be used for, so I 
can't really comment on it. Same for keyusermanager.  Maybe, the lack of 
comments is the source for all my questions below.

- The DTOR of AlkUser does not delete the private 'd' memory. This will result 
in memory leaks.

- What is 'Q_String'? Please use QString as type in alkuser.cpp

- The line

  class ALK_EXport AlkUser : public QObject

in alkuser.h should read

  class ALK_EXPORT AlkUser : public QObject

to work properly.


- There is no CMakeLists.txt file which would allow to build the software.

- Why is the amount attribute a QString and not an AlkValue?



> And even i was not able to use any test over these.

What are you trying to accomplish? Please try to explain what you are trying 
to achieve with those objects.  We can certainly help.


-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
'Knowing a computer language is neither a necessary nor a sufficient
condition to know how to construct a computer program' -- J.R. Tyrer
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 225 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-finance-apps/attachments/20110710/99bbddc4/attachment.sig