[Kde-extra-gear] add_definitions in common CMakeLists.txt

[Thiago Macieira]

Ian Monroe wrote:
>So is it OK If I remove this line from multimedia/CMakeLists.txt:
>add_definitions (${QT_DEFINITIONS} ${KDE4_DEFINITIONS})
>
>I'll make sure that the module still compiles.

That's not exactly a good idea. If you remove that line, you don't get the 
debug/release setting, for instance. (It's controlled by a #define)

Those above should be safe. Can you tell us what the issues are? We should 
address each one individually.

Also, you can have the same effect by moving the add_directory above the 
add_definitions.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-extra-gear/attachments/20080703/7c01d8ee/attachment.pgp