D26712: Multiple Dataset for enumerate

[Johnny Jazeix]

jjazeix added a comment.


  Almost ok for me :).
  We shouldn't be able to click multiple times on "ok" quickly to validate 2 levels at same time. 
  When a fruit is under the instructions, we can't move it. I think it would be better to have clicks on fruits move them (always), and if click is on the window, show/hide the instruction. Instructions should always be displayed above the fruits.
  
  @echarruau we still have visual feedback (green color on the box) when we put a correct answer. Shouldn't we update it to be an hint instead (to not remove the feature but this way, the child can know which one is good or wrong)?

INLINE COMMENTS

> enumerate.js:118
>          if(userAnswers[key] !== answerToFind[key]) {
> -            return;
> +            return items.bonus.bad("smiley")
>          }

it should be:

  items.bonus.bad("smiley")
  return

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D26712

To: shubhammishra, #gcompris_improvements, jjazeix, echarruau
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200122/2f26b5d8/attachment.html>