<table><tr><td style="">jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26712">View Revision</a></tr></table><br /><div><div><p>Almost ok for me :).<br />
We shouldn't be able to click multiple times on "ok" quickly to validate 2 levels at same time. <br />
When a fruit is under the instructions, we can't move it. I think it would be better to have clicks on fruits move them (always), and if click is on the window, show/hide the instruction. Instructions should always be displayed above the fruits.</p>
<p><a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> we still have visual feedback (green color on the box) when we put a correct answer. Shouldn't we update it to be an hint instead (to not remove the feature but this way, the child can know which one is good or wrong)?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26712#inline-151678">View Inline</a><span style="color: #4b4d51; font-weight: bold;">enumerate.js:118</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">userAnswers</span><span class="p">[</span><span style="color: #004012">key</span><span class="p">]</span> <span style="color: #aa2211">!==</span> <span style="color: #004012">answerToFind</span><span class="p">[</span><span style="color: #004012">key</span><span class="p">])</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">return<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return<span class="bright"></span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">bonus</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">bad</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"smiley"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it should be:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">items.bonus.bad("smiley")
return</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26712">https://phabricator.kde.org/D26712</a></div></div><br /><div><strong>To: </strong>shubhammishra, GCompris: Improvements, jjazeix, echarruau<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>