D23892: Fix HFR calculation, add HFR on focus view, adjust focus UI.

Jasem Mutlaq noreply at phabricator.kde.org
Thu Sep 12 07:28:02 BST 2019

mutlaqja requested changes to this revision.
mutlaqja added a comment.
This revision now requires changes to proceed.

  Awesome addition to the module and thank you for catching the accumulator issue.


> focus.ui:9
>      <y>0</y>
> -    <width>697</width>
> -    <height>537</height>
> +    <width>884</width>
> +    <height>646</height>

Width must be less than 800 pixels to conform with the rest of the Ekos interface.

> fitsview.cpp:946
> +        QFont painterFont;
> +        painterFont.setPointSizeF(painterFont.pointSizeF() * 3 * ratio);
> +        painter->setFont(painterFont);

That seems a bit too large when it is subframed. Also, the number is clipped. Maybe it should be Above the star? or maybe it should be smaller in this case?

> fitsview.cpp:952
> -    for (int i = 0; i < starCenters.count(); i++)
> +    foreach (Edge *starCenter, imageData->getStarCenters())
>      {

for(const auto &center: imageData->getStarCenters())

  R321 KStars


To: TallFurryMan, mutlaqja, alexcherney, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190912/70f7b772/attachment.html>

More information about the kde-edu mailing list