D23892: Fix HFR calculation, add HFR on focus view, adjust focus UI.

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, alexcherney, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  Fixed HFR calculation in the FITSData class, which was accumulating integer instead of double values.
  This led to incorrect consolidation of HFR over multiple stars in the focus procedure and incoherent results in full-frame mode.
  
  In order to debug, added HFR values directly in the FITS view, next to circular star marks.
  The HFR values are now displayed only for the focus module, they do not appear in the regular FITS viewer.
  
  Took the opportunity to adjust the Focus module UI, so that buttons are bigger and a few UI hiccups are resolved.
  
  Notes:
  
  At the time of this differential, the FITS viewer and the Focus module do not detect the same amount of stars.
  Apparently, the "JMIndex" in the case of the FITS viewer is taken from the histogram, and equals 0, causing the detection threshold to be computed from the frame mean ADU, and set too high.
  The "JMIndex" in the case of the Focus module is left to its default value 100, causing the detection threshold to be computed from the frame standard deviation, and set properly.
  
  On another subject, the CCD Simulator seems to produce the same SNR even as the optical simulation approaches the optimal focus point.
  This causes rendered stars to be smaller, and thus to be missed by the FITS detector. In other words, the more focused the frame is, the less stars are detected.
  Because of this problem, the focus procedure sometimes fails with the CCD Simulator.

TEST PLAN
  - Run an autofocus procedure using the CCD Simulator or a real CCD night test so that a dozen of stars are detected.
  - Verify the HFR consolidated for a particular focuser position is the mean value of HFR registered for detected stars.
  - Verify the procedure is overall more stable than before the change.

REPOSITORY
  R321 KStars

BRANCH
  improve__stacked_focus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23892

AFFECTED FILES
  kstars/ekos/focus/focus.cpp
  kstars/ekos/focus/focus.ui
  kstars/fitsviewer/fitsdata.cpp
  kstars/fitsviewer/fitsview.cpp
  kstars/fitsviewer/fitsview.h

To: TallFurryMan, mutlaqja, alexcherney, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190911/9a34df4a/attachment-0001.html>