D20001: Simplifying Scheduler

[Eric Dejouhanet]

TallFurryMan added a comment.


  I fully agree, but that means darkness and weather should go in ScheduleStrategy, and altitude score and moon separation score calculations should go to SchedulerJob.
  Also, are you sure you need a separate class for now? Could you keep the code in Scheduler, but move it to a different source file?
  That would prepare the codebase with zero risk of regression, and discuss what goes where. scheduler_strategy.cpp and scheduler_schedulerjob.cpp?
  
  Alternately, we could say that if calculating a score, when all is needed from SchedulerJob is one characteristic, perhaps the code may take that characteristic instead of passing the full SchedulerJob.
  That would reduce the inter-dependencies. In these conditions, we see that the altitude score calculation is not dependent on SchedulerJob, but on altitude and time calculation should be done at.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D20001

To: wreissenberger, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190324/2cfd2d69/attachment.html>