D21461: Multiplle datasets for money activity
noreply at phabricator.kde.org
Tue Jun 4 16:05:55 BST 2019
AkshayCHD marked an inline comment as done.
AkshayCHD added inline comments.
> jjazeix wrote in money.js:74
> I would use the dataset moneyItems, not directly the Constants one. Else the specific items won't be used.
@jjazeix But there is a problem with using the dataset's moneyItems. If suppose we need to find change for 100 units paid, then the pocket values might not contain a 100 units note, it might instead contain one 50 units, two 20 units and one 10 units notes. So instead of just one 100 units note, tux will now hold 4 notes will would require alot of space and would hinder the visibility of individual notes.
> jjazeix wrote in money.js:86
> I think the part: (avaliableCurrency[i].val > amountToBeCovered) is not needed because it should always be the case before breaking as we start from the higher value in a sorted array.
The dataset is sorted in ascending order that is why i added that condition, but yes it won't be needed if i sort it in descending order. Will do that
To: AkshayCHD, #gcompris_improvements
Cc: asagtani, jjazeix, kde-edu, #gcompris_improvements, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-edu