D22507: Tooltip Framework for m_statsTable in HypothesisTestView

[Devanshu Agarwal]

devanshuagarwal marked an inline comment as done.
devanshuagarwal added inline comments.

INLINE COMMENTS

> asemke wrote in HypothesisTest.cpp:1578
> You can create in the constructor of the cell and ID, a random number, and work with cell->id() here to avoid collisions.

No, I don't think that can be done. Because when the user clicks on the word, the information we get is the global position and data of the selected word. While creating the map we didn't know apriori the global position of the word where the tooltip is to be set.

So, to avoid collisions, we have to work on getting the global position of each word apriori.

> asemke wrote in HypothesisTest.h:85
> I don't see this done. It's still a pointer here with the object created with new in the constructor and without any delete in the destructor.

Ok, I had done removed pointer from tooltips as I also found it unnecessary. Now, for all pointers I created, I have deleted them.

> asemke wrote in HypothesisTestPrivate.h:103
> we have already AbstractColumn::isNumeric() returning true for  AbstractColumn::Numeric and AbstractColumn::Integer. Please check whether you can use this functions.

Yes,  I am using that only to actually the function definition is:

  bool GeneralTest::isNumericOrInteger(const Column* column) {
      return (column->columnMode() == AbstractColumn::Numeric || column->columnMode() == AbstractColumn::Integer);
  }

Its is just that this is used many times in code so I wanted to use something short. 
Is using macro for this purpose more appropriate?

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22507

To: devanshuagarwal, sgerlach, asemke
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190728/e61b6816/attachment-0001.html>