D18476: Fixing

[Stefan Gerlach]

sgerlach added inline comments.

INLINE COMMENTS

> DateTimeSpinBox.cpp:14
> +
> +	QRegularExpression regExp("([0-9]+)\.(0[0-9]|1[0-2]|[0-9])\.(0[0-9]|[0-2][0-9]|30|[0-9]) ([0-1][0-9]|2[0-3]|[0-9])\:([0-5][0-9]|[0-9])\:([0-5][0-9]|[0-9])\.[0-9]{0,3}");
> +	m_regularExpressionValidator->setRegularExpression(regExp);

warning: unknown escape sequence: '\.'

> DateTimeSpinBox.cpp:23
> +	if (event->key() >= Qt::Key_0 && event->key() <= Qt::Key_9) {
> +		Type type = determineType(lineEdit()->cursorPosition());
> +		QAbstractSpinBox::keyPressEvent(event);

warning: unused variable ‘type’

> DateTimeSpinBox.cpp:201
> +
> +bool DateTimeSpinBox::changeValue(qint64& thisType, qint64& nextType, DateTimeSpinBox::Type nextTypeType, int step) {
> +

warning: unused parameter ‘nextType’

> DateTimeSpinBox.cpp:204
> +	int maxValue = 0;
> +	switch (nextTypeType) {
> +		case (Type::year):

warning: enumeration value ‘millisecond’ not handled in switch

> DateTimeSpinBox.h:29
> +	void stepBy(int steps) override;
> +	QAbstractSpinBox::StepEnabled stepEnabled() const;
> +        bool increaseValue(Type type, int step);

warning: 'stepEnabled' overrides a member function but is not marked 'override'

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D18476

To: Murmele, asemke
Cc: sgerlach, yurchor, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190123/b7eed128/attachment-0001.html>