<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18476">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18476#inline-102217">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DateTimeSpinBox.cpp:14</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QRegularExpression</span> <span style="color: #004012">regExp</span><span class="p">(</span><span style="color: #766510">"([0-9]+)</span><span class="err">\</span><span class="p">.(</span><span style="color: #601200">0</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">]</span><span style="color: #aa2211">|</span><span style="color: #601200">1</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">2</span><span class="p">]</span><span style="color: #aa2211">|</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">])</span><span class="err">\</span><span class="p">.(</span><span style="color: #601200">0</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">]</span><span style="color: #aa2211">|</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">2</span><span class="p">][</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">]</span><span style="color: #aa2211">|</span><span style="color: #601200">30</span><span style="color: #aa2211">|</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">])</span> <span class="p">([</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">][</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">]</span><span style="color: #aa2211">|</span><span style="color: #601200">2</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">3</span><span class="p">]</span><span style="color: #aa2211">|</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">])</span><span class="err">\</span><span style="color: #aa2211">:</span><span class="p">([</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">5</span><span class="p">][</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">]</span><span style="color: #aa2211">|</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">])</span><span class="err">\</span><span style="color: #aa2211">:</span><span class="p">([</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">5</span><span class="p">][</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">]</span><span style="color: #aa2211">|</span><span class="p">[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">])</span><span class="err">\</span><span class="p">.[</span><span style="color: #601200">0</span><span style="color: #aa2211">-</span><span style="color: #601200">9</span><span class="p">]{</span><span style="color: #601200">0</span><span class="p">,</span><span style="color: #601200">3</span><span class="p">}</span><span style="color: #766510">");</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">m_regularExpressionValidator</span><span style="color: #aa2211">-></span><span class="n">setRegularExpression</span><span class="p">(</span><span class="n">regExp</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">warning: unknown escape sequence: '\.'</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18476#inline-102218">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DateTimeSpinBox.cpp:23</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">key</span><span class="p">()</span> <span style="color: #aa2211">>=</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_0</span> <span style="color: #aa2211">&&</span> <span class="n">event</span><span style="color: #aa2211">-></span><span class="n">key</span><span class="p">()</span> <span style="color: #aa2211"><=</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_9</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Type</span> <span class="n">type</span> <span style="color: #aa2211">=</span> <span class="n">determineType</span><span class="p">(</span><span class="n">lineEdit</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">cursorPosition</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QAbstractSpinBox</span><span style="color: #aa2211">::</span><span class="n">keyPressEvent</span><span class="p">(</span><span class="n">event</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">warning: unused variable ‘type’</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18476#inline-102221">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DateTimeSpinBox.cpp:201</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">bool</span> <span class="n">DateTimeSpinBox</span><span style="color: #aa2211">::</span><span class="n">changeValue</span><span class="p">(</span><span class="n">qint64</span><span style="color: #aa2211">&</span> <span class="n">thisType</span><span class="p">,</span> <span class="n">qint64</span><span style="color: #aa2211">&</span> <span class="n">nextType</span><span class="p">,</span> <span class="n">DateTimeSpinBox</span><span style="color: #aa2211">::</span><span class="n">Type</span> <span class="n">nextTypeType</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">step</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">warning: unused parameter ‘nextType’</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18476#inline-102219">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DateTimeSpinBox.cpp:204</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">int</span> <span class="n">maxValue</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">switch</span> <span class="p">(</span><span class="n">nextTypeType</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">case</span> <span class="p">(</span><span class="n">Type</span><span style="color: #aa2211">::</span><span class="n">year</span><span class="p">)</span><span style="color: #aa2211">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">warning: enumeration value ‘millisecond’ not handled in switch</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18476#inline-102222">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DateTimeSpinBox.h:29</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">void</span> <span style="color: #004012">stepBy</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">steps</span><span class="p">)</span> <span class="n">override</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QAbstractSpinBox</span><span style="color: #aa2211">::</span><span class="n">StepEnabled</span> <span class="n">stepEnabled</span><span class="p">()</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">bool</span> <span style="color: #004012">increaseValue</span><span class="p">(</span><span class="n">Type</span> <span class="n">type</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">step</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">warning: 'stepEnabled' overrides a member function but is not marked 'override'</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18476">https://phabricator.kde.org/D18476</a></div></div><br /><div><strong>To: </strong>Murmele, asemke<br /><strong>Cc: </strong>sgerlach, yurchor, kde-edu, narvaez, apol<br /></div>