D17861: Prevent instructions from disappearing

emmanuel charruau noreply at phabricator.kde.org
Thu Jan 3 13:06:01 GMT 2019


echarruau added a comment.


  I am not sure but I think that the isntructions were initially in an external file?
  Why did they move into the code?

INLINE COMMENTS

> share.js:106
> +        items.instruction.widgetVisible = false
>          items.instruction.text += qsTr("Then equally split %n pieces of candy between them.", "Third part of Place %n boy(s) and %n girl(s) in the center. Then equally split %n pieces of candy between them.", items.totalCandies);
> +        items.instruction.toggleElide()

Why have the instruction been moved to the code? Were they not in a separate file?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17861

To: AkshayCHD, #gcompris_improvements
Cc: echarruau, jjazeix, kde-edu, #gcompris_improvements, harrymecwan, ganeshredcobra, nityanandkumar, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190103/18b5c5c4/attachment.html>


More information about the kde-edu mailing list