<table><tr><td style="">echarruau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17861">View Revision</a></tr></table><br /><div><div><p>I am not sure but I think that the isntructions were initially in an external file?<br />
Why did they move into the code?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17861#inline-98741">View Inline</a><span style="color: #4b4d51; font-weight: bold;">share.js:106</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">instruction</span><span class="p">.</span><span style="color: #004012">widgetVisible</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">instruction</span><span class="p">.</span><span style="color: #004012">text</span> <span style="color: #aa2211">+=</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Then equally split %n pieces of candy between them."</span><span class="p">,</span> <span style="color: #766510">"Third part of Place %n boy(s) and %n girl(s) in the center. Then equally split %n pieces of candy between them."</span><span class="p">,</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">totalCandies</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright">        </span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">instruction</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">toggleElide</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why have the instruction been moved to the code? Were they not in a separate file?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17861">https://phabricator.kde.org/D17861</a></div></div><br /><div><strong>To: </strong>AkshayCHD, GCompris: Improvements<br /><strong>Cc: </strong>echarruau, jjazeix, kde-edu, GCompris: Improvements, harrymecwan, ganeshredcobra, nityanandkumar, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin<br /></div>