D17861: Prevent instructions from disappearing

Johnny Jazeix noreply at phabricator.kde.org
Thu Jan 3 12:16:36 GMT 2019

jjazeix added inline comments.


> Share.qml:260
> +            //to change width of instruction enclosing box with change in width of instruction text
> +            onWidthChanged: {
> +                instruction.width = width

why not always set instruction.width/height to instructionTxt.width/height using normal binding?

> Share.qml:268
>              opacity: instruction.opacity
> +            height: background.height - (bar.height + 500)
> +            elide: Text.ElideRight

why 500?

> share.js:60
> +        items.instruction.widgetVisible = false
>          items.instruction.text = subLevelData.instruction

when you toggle 2 lines below, you also change the visible, is it normal to do it twice?

> share.js:105
>          //~ plural Then equally split %n candies between them.
> +        items.instruction.widgetVisible = false
>          items.instruction.text += qsTr("Then equally split %n pieces of candy between them.", "Third part of Place %n boy(s) and %n girl(s) in the center. Then equally split %n pieces of candy between them.", items.totalCandies);

same as above

  R2 GCompris


To: AkshayCHD, #gcompris_improvements
Cc: jjazeix, kde-edu, #gcompris_improvements, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190103/bdab257f/attachment.html>

More information about the kde-edu mailing list