<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17861">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17861#inline-98736">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Share.qml:260</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #74777d">//to change width of instruction enclosing box with change in width of instruction text</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">onWidthChanged:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #004012">instruction</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">=</span> <span style="color: #004012">width</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why not always set instruction.width/height to instructionTxt.width/height using normal binding?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17861#inline-98733">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Share.qml:268</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">opacity:</span> <span style="color: #004012">instruction</span><span class="p">.</span><span style="color: #004012">opacity</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">height:</span> <span style="color: #004012">background</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #004012">bar</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #601200">500</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">elide:</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">ElideRight</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why 500?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17861#inline-98734">View Inline</a><span style="color: #4b4d51; font-weight: bold;">share.js:60</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">instruction</span><span class="p">.</span><span style="color: #004012">widgetVisible</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">instruction</span><span class="p">.</span><span style="color: #004012">text</span> <span style="color: #aa2211">=</span> <span style="color: #004012">subLevelData</span><span class="p">.</span><span style="color: #004012">instruction</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">when you toggle 2 lines below, you also change the visible, is it normal to do it twice?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17861#inline-98735">View Inline</a><span style="color: #4b4d51; font-weight: bold;">share.js:105</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">//~ plural Then equally split %n candies between them.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">instruction</span><span class="p">.</span><span style="color: #004012">widgetVisible</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">instruction</span><span class="p">.</span><span style="color: #004012">text</span> <span style="color: #aa2211">+=</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Then equally split %n pieces of candy between them."</span><span class="p">,</span> <span style="color: #766510">"Third part of Place %n boy(s) and %n girl(s) in the center. Then equally split %n pieces of candy between them."</span><span class="p">,</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">totalCandies</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same as above</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17861">https://phabricator.kde.org/D17861</a></div></div><br /><div><strong>To: </strong>AkshayCHD, GCompris: Improvements<br /><strong>Cc: </strong>jjazeix, kde-edu, GCompris: Improvements, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin<br /></div>