D19231: update default server to kde one to download data

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Feb 22 19:08:26 GMT 2019


apol added inline comments.

INLINE COMMENTS

> ApplicationSettings.cpp:157
> +    m_downloadServerUrl = m_config.value(DOWNLOAD_SERVER_URL_KEY, QLatin1String(DEFAULT_DOWNLOAD_SERVER)).toString();
> +    if(m_downloadServerUrl == "http://gcompris.net") {
> +        setDownloadServerUrl(DEFAULT_DOWNLOAD_SERVER);

these are char* so == doesn't work.

Make them (or at least either) a QLatin1String, otherwise you'll be comparing pointers.

REVISION DETAIL
  https://phabricator.kde.org/D19231

To: jjazeix, #gcompris_improvements
Cc: apol, kde-edu, narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190222/0e1f2a18/attachment.html>


More information about the kde-edu mailing list