<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19231">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19231#inline-107381">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ApplicationSettings.cpp:157</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_downloadServerUrl</span> <span style="color: #aa2211">=</span> <span class="n">m_config</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">DOWNLOAD_SERVER_URL_KEY</span><span class="p">,</span> <span class="n">QLatin1String</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"http://gcompris.net"</span></span><span class="p">)).</span><span class="n">toString</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_downloadServerUrl</span> <span style="color: #aa2211">=</span> <span class="n">m_config</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">DOWNLOAD_SERVER_URL_KEY</span><span class="p">,</span> <span class="n">QLatin1String</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">DEFAULT_DOWNLOAD_SERVER</span></span><span class="p">)).</span><span class="n">toString</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">m_downloadServerUrl</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"http://gcompris.net"</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">setDownloadServerUrl</span><span class="p">(</span><span class="n">DEFAULT_DOWNLOAD_SERVER</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">these are char* so == doesn't work.</p>

<p style="padding: 0; margin: 8px;">Make them (or at least either) a QLatin1String, otherwise you'll be comparing pointers.</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19231">https://phabricator.kde.org/D19231</a></div></div><br /><div><strong>To: </strong>jjazeix, GCompris: Improvements<br /><strong>Cc: </strong>apol, kde-edu, narvaez<br /></div>