D19231: update default server to kde one to download data

Johnny Jazeix noreply at phabricator.kde.org
Fri Feb 22 19:37:02 GMT 2019


jjazeix added inline comments.

INLINE COMMENTS

> apol wrote in ApplicationSettings.cpp:157
> these are char* so == doesn't work.
> 
> Make them (or at least either) a QLatin1String, otherwise you'll be comparing pointers.

m_downloadServerUrl is a QString and there is a operator==(const char *) (https://doc.qt.io/qt-5/qstring.html#operator-eq-eq-1) so it is fine?

REVISION DETAIL
  https://phabricator.kde.org/D19231

To: jjazeix, #gcompris_improvements
Cc: apol, kde-edu, narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190222/7766b31a/attachment-0001.html>


More information about the kde-edu mailing list