D22910: Replace obsolete QSignalMapper and qSort with non-obsolete code

Yuri Chornoivan noreply at phabricator.kde.org
Sat Aug 3 17:58:11 BST 2019


yurchor created this revision.
yurchor added reviewers: KDE Edu, gottfried.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
yurchor requested review of this revision.

REVISION SUMMARY
  qSort and QSignalMapper are deprecated and spoil the compilation messages with warnings:
  
  https://build.kde.org/job/Applications/job/ktouch/job/kf5-qt5%20FreeBSDQt5.13/10/warnings12Result/
  
  This patch tries to get rid of these warnings.

TEST PLAN
  1. Compile (there should be no warnings with Qt 5.13).
  2. Run KTouch, open the course and layout editor and create a course. The new item should be correctly added to the lists in the Editor and the main KTouch window. Delete the course.
  3. Add a layout. Add a key. Resize the key. KTouch should behave as expected. Remove the layout.

REPOSITORY
  R336 KTouch

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22910

AFFECTED FILES
  src/core/course.cpp
  src/core/keyboardlayout.cpp
  src/models/charactersmodel.cpp
  src/models/errorsmodel.cpp
  src/models/lessonmodel.cpp
  src/models/resourcemodel.cpp
  src/models/resourcemodel.h

To: yurchor, #kde_edu, gottfried
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190803/4972796a/attachment.html>


More information about the kde-edu mailing list