D21841: Multiple datasets for money and smallnumbers activity

[Sagar Chand Agarwal]

scagarwal reopened this revision.
scagarwal added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> gletters.js:82
>              items.ourActivity.dataSetUrl + "default-"+locale+".json"));
> +    else
> +        items.wordlist.loadFromJSON(items.levels);

@AkshayCHD The code misses starting and closing braces. Do add them.

> gletters.js:101
> +            items.ourActivity.dataSetUrl + "default-"+localeShort+".json"));
> +        else
> +            items.wordlist.loadFromJSON(items.levels);

@AkshayCHD The code misses starting and closing braces. Do add them.

> gletters.js:119
> +    if(items.levels)
> +        items.instructionText = items.levels[currentLevel].objective
>      items.audioVoices.clearQueue()

@AkshayCHD The code misses starting and closing braces. Do add them.

> money.js:69
>  
> +function getCoinCount (pocket) {
> +    var count = 0

Remove the space between Function Name and Parameters.

> money.js:185
>  function getRandomObject(price) {
> -    var list
> +    var objectList
>      if(price < 5)

@AkshayCHD The code misses starting and closing braces. Do add them.

REPOSITORY
  R2 GCompris

BRANCH
  gsoc_akshaychd_multiple_datasets

REVISION DETAIL
  https://phabricator.kde.org/D21841

To: AkshayCHD, #gcompris_improvements, jjazeix
Cc: scagarwal, echarruau, jjazeix, kde-edu, #gcompris_improvements, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, asagtani, nityanandkumar, andreask, rahulyadav, narvaez, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190813/a540af3a/attachment.html>