D17494: Allow translation of the style plugin names in molecule viewer

Yuri Chornoivan noreply at phabricator.kde.org
Sun Dec 16 09:01:58 GMT 2018


yurchor added a comment.


  In D17494#377816 <https://phabricator.kde.org/D17494#377816>, @pino wrote:
  
  > The approach here should be changed: instead of hardcoding the names of plugins in the `styleCombo`, they ought to be read directly from the `sceneModel()` of the GL widget. This way:
  >
  > 1. the strings come directly from avogadro itself, no more need to translate them in kalzium
  > 2. the list of styles reflects what avogadro provides, so no more mismatch between what is hardcoded in kalzium vs the plugins avogadro has
  > 3. the documentation of kalzium ought to better not list all the plugins/styles available, since they depend on what avogadro has (mentioning a couple is more than enough, IMHO)
  >
  >   This also means that more i18n work is needed in avogadro itself.
  
  
  What is the way to proceed?
  
  It seems I have a good friction with the current Avogadro maintainers. What should be changed? The translations are in the repo and on Launchpad, just not packed by the distributions.
  
  Should I abandon this revision for some better times?
  
  Could someone shake some salt of knowledge on my life about how to fix this "in model"?
  
  Why it was good to use such an approach for other parts of Kalzium (can be easily proven by searching "->addItem")?
  
  Thanks in advance for your answers.

REPOSITORY
  R326 Kalzium

REVISION DETAIL
  https://phabricator.kde.org/D17494

To: yurchor, #kde_edu, pino
Cc: kde-doc-english, pino, kde-edu, skadinna, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181216/6d92dc54/attachment.html>


More information about the kde-edu mailing list