D17559: Prepare Kalzium components (liscience and compound viewer) for compiling with -DQT_NO_CAST_FROM_ASCII

[Albert Astals Cid]

aacid added a comment.


  I really doubt QT_NO_CAST_FROM_ASCII will even be default even mandatory.

INLINE COMMENTS

> moleculeparser.cpp:251
>      if ('A' <= nextChar() && nextChar() <= 'Z') {
> -        name = char(nextChar());
> +        name = QChar(nextChar());
>          getNextChar();

i've a bit afraid of this one, you're not using QChar(int) instead of QChar(char) (i guess) that was being used before.

The actual proper port would be QChar::fromLatin1(char(nextchar())), no?

REPOSITORY
  R326 Kalzium

REVISION DETAIL
  https://phabricator.kde.org/D17559

To: yurchor, #kde_edu
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181215/f9694ad4/attachment.html>