D17559: Prepare Kalzium components (liscience and compound viewer) for compiling with -DQT_NO_CAST_FROM_ASCII

[Yuri Chornoivan]

yurchor abandoned this revision.
yurchor added a comment.


  In D17559#377363 <https://phabricator.kde.org/D17559#377363>, @aacid wrote:
  
  > I really doubt QT_NO_CAST_FROM_ASCII will even be default even mandatory.
  
  
  Ok. Thanks.
  
  I had started the final step of removing kdelibs4support with
  
    include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
  
  in CMakeLists.txt. Taking the wrong way, I decided to add QLatin1String() and Q_SLOT everywhere. Even tried to patch libavogadro:
  
  https://github.com/OpenChemistry/avogadrolibs/pull/414
  
  It appears that things are much simpler and porting was deadly easy. ;)
  
  https://cgit.kde.org/kalzium.git/commit/?id=1c906b21a6b5d1f80a6a93b4cf384239d125ada4
  
  https://cgit.kde.org/kalzium.git/commit/?id=c000bb62873bf5cdcd8ee3394e947336e6d859f2
  
  Then I decided to do something with the patched parts... It's good to know they are actually not necessary. :)

REPOSITORY
  R326 Kalzium

REVISION DETAIL
  https://phabricator.kde.org/D17559

To: yurchor, #kde_edu
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181215/ea85656a/attachment.html>