D16663: [import] Fix leaking AbstractFileFilters

Christoph Roick noreply at phabricator.kde.org
Fri Dec 7 15:37:54 GMT 2018

croick added inline comments.


> asemke wrote in LiveDataSource.cpp:252
> According to the c++-11 standard (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3242.pdf, 5.3.5/7), it's an unspecified behavior for the null pointer case.

Which means, that `operator delete(void* ptr)` either is called or not. And if it is called, then applies, which states, that it does nothing if `ptr` is a null pointer.

> asemke wrote in ImportFileWidget.cpp:595
> Right, I overlooked this important part with omitting the reparsing of the file. But also this can be done with the raw pointers. Which inconsistency with the options widgets do you mean?

They are all `unique_ptr`s and there is no explicit `delete` in `~ImportFilterWidget()`.

  R262 LabPlot


To: croick, #labplot, asemke
Cc: asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181207/ab8bd329/attachment.html>

More information about the kde-edu mailing list