D16663: [import] Fix leaking AbstractFileFilters

[Alexander Semke]

asemke accepted this revision.
asemke added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> croick wrote in LiveDataSource.cpp:252
> Which means, that `operator delete(void* ptr)` either is called or not. And if it is called, then 18.6.1.1/14 applies, which states, that it does nothing if `ptr` is a null pointer.

It's never too late to learn.. Thanks.

> croick wrote in ImportFileWidget.cpp:595
> They are all `unique_ptr`s and there is no explicit `delete` in `~ImportFilterWidget()`.

I see. Those unique pointers introduced already some inconsistency when compared to the other code in LabPlot :-) But ok. Let's go for this solution.

REPOSITORY
  R262 LabPlot

BRANCH
  filterpointer

REVISION DETAIL
  https://phabricator.kde.org/D16663

To: croick, #labplot, asemke
Cc: asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181208/531d88ad/attachment.html>