D16663: [import] Fix leaking AbstractFileFilters

Alexander Semke noreply at phabricator.kde.org
Fri Dec 7 08:24:33 GMT 2018


asemke added inline comments.

INLINE COMMENTS

> croick wrote in LiveDataSource.cpp:252
> Actually nothing happens when deleting a nullptr (https://en.cppreference.com/w/cpp/language/delete). The check would be redundant. For newer versions of C++ this assumption seems to change a little, in case a non-standard deallocator is used – which we don't, the standard deallocator just does nothing with a nullptr.

According to the c++-11 standard (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3242.pdf, 5.3.5/7), it's an unspecified behavior for the null pointer case.

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D16663

To: croick, #labplot, asemke
Cc: asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181207/68e1150d/attachment.html>


More information about the kde-edu mailing list