D12381: programmingMaze, code clean-up revision #2

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> HeaderArea.qml:41
> +        height: parent.height - 2 * parent.border.width
> +        x: parent.border.width
> +        y: x

is it a margin? Better use margins than x/y positions.

> InstructionArea.qml:69
> +        border.color: "purple"
> +        y: 1.5 * ApplicationInfo.ratio
> +        z: 2

anchors?

> InstructionArea.qml:105
> +
> +            onPressed:  instructionItem.checkModelAndInsert()
> +        }

2 spaces

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12381

To: amankumargupta, #gcompris_improvements
Cc: jjazeix, #kde_edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180420/fa04d9ee/attachment-0001.html>