D12381: programmingMaze, code clean-up revision #2

[Aman Kumar Gupta]

amankumargupta marked 3 inline comments as done.
amankumargupta added inline comments.

INLINE COMMENTS

> jjazeix wrote in HeaderArea.qml:41
> is it a margin? Better use margins than x/y positions.

yes, it's a margin. But anyways, anchors.centerIn does the job :)

> jjazeix wrote in InstructionArea.qml:69
> anchors?

On testing now, I felt there's no need for the additional 1.5 * ApplicationInfo.ratio. Removed it in the updated diff.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12381

To: amankumargupta, #gcompris_improvements
Cc: jjazeix, #kde_edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180420/069f96a5/attachment.html>