D12381: programmingMaze, code clean-up revision #2

Aman Kumar Gupta noreply at phabricator.kde.org
Fri Apr 20 13:46:53 UTC 2018


amankumargupta added inline comments.

INLINE COMMENTS

> HeaderArea.qml:1
> +/* GCompris - HeaderArea.qml
> + *

This is a new file for header area which was previously repeated 3 times in the file ProgrammingMaze.qml for all the three areas: instruction area, main area and procedure area (line 483 - 604 in the diff).

This is now generalized thus making the code much cleaner and less-redundant.

Much of the content in this file is same as previous, except two new properties are defined to specify the header text and vary opacity according to different area's needs.

> InstructionArea.qml:1
> +/* GCompris - InstructionArea.qml
> + *

This is the file for instruction area.

The entire code is moved here from line 256 - 399 in the diff, making the main file shorter and more readible.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12381

To: amankumargupta, #gcompris_improvements
Cc: #kde_edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180420/1afd04e5/attachment.html>


More information about the kde-edu mailing list