Review Request 127881: Fix theme cache path handling

Andreas Cord-Landwehr cordlandwehr at kde.org
Fri May 27 10:48:20 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127881/#review95913
-----------------------------------------------------------


Ship it!




Ship It!

- Andreas Cord-Landwehr


On Mai 10, 2016, 7:50 vorm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127881/
> -----------------------------------------------------------
> 
> (Updated Mai 10, 2016, 7:50 vorm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> When path to theme cache file does not exitst (e.g. after a fresh
> installation) it is not created automatically which caused the
> following error to be shown on stderr while reading and writing:
> 
> "QIODevice::read (QFile, "/path/to/theme/cache/startpagethemecache.bin"
> ): device not open"
> 
> Automatic creation of theme cache path is added. Location of cache file
> is moved to QStandardPaths::CacheLocation.
> 
> Because for me it looks like that the theme image cache is what its name shows, a cache. I think that it's better to store it at QStandardPaths::CacheLocation rather then QStandardPaths::DataLocation.
> 
> 
> Diffs
> -----
> 
>   src/practice/imagecache.h 26afb8a5439d0909a8410c992eadd9cbe021fc5c 
>   src/practice/imagecache.cpp 9d01395804c6bce3551743292790e6b642ab9337 
>   src/practice/themedbackgroundrenderer.cpp 7623d69369e189abd66c4fff39b023fae32b73d1 
> 
> Diff: https://git.reviewboard.kde.org/r/127881/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160527/d9ae4e73/attachment.html>


More information about the kde-edu mailing list