Review Request 127881: Fix theme cache path handling

Hartmut Riesenbeck hartmut.riesenbeck at gmx.de
Sun May 29 15:58:04 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127881/
-----------------------------------------------------------

(Updated May 29, 2016, 3:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Changes
-------

Submitted with commit f766452408cc64a75b8782e499a6a8c4f64b3ba2 by Hartmut Riesenbeck to branch master.


Repository: parley


Description
-------

When path to theme cache file does not exitst (e.g. after a fresh
installation) it is not created automatically which caused the
following error to be shown on stderr while reading and writing:

"QIODevice::read (QFile, "/path/to/theme/cache/startpagethemecache.bin"
): device not open"

Automatic creation of theme cache path is added. Location of cache file
is moved to QStandardPaths::CacheLocation.

Because for me it looks like that the theme image cache is what its name shows, a cache. I think that it's better to store it at QStandardPaths::CacheLocation rather then QStandardPaths::DataLocation.


Diffs
-----

  src/practice/imagecache.h 26afb8a5439d0909a8410c992eadd9cbe021fc5c 
  src/practice/imagecache.cpp 9d01395804c6bce3551743292790e6b642ab9337 
  src/practice/themedbackgroundrenderer.cpp 7623d69369e189abd66c4fff39b023fae32b73d1 

Diff: https://git.reviewboard.kde.org/r/127881/diff/


Testing
-------


Thanks,

Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160529/bdf031fc/attachment.html>


More information about the kde-edu mailing list