Review Request 127156: Call off EntryFilter::expireEntries has no effect
Andreas Cord-Landwehr
cordlandwehr at kde.org
Wed Mar 9 20:55:37 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127156/#review93369
-----------------------------------------------------------
Ship it!
Ship It!
- Andreas Cord-Landwehr
On März 6, 2016, 7:55 nachm., Hartmut Riesenbeck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127156/
> -----------------------------------------------------------
>
> (Updated März 6, 2016, 7:55 nachm.)
>
>
> Review request for KDE Edu.
>
>
> Repository: parley
>
>
> Description
> -------
>
> In EntryFilter::expireEntries() the set
> EntryFilter::m_entries is checked for entries
> which hasn't practiced for a defined amount of
> time and decreases the grad if this was expired.
>
> But at time of calling expireEntries() this could
> not work because m_entries was not intialisised
> and empty. The method call was moved to a place
> where m_entries is filled and cleaned of invalid
> entries.
>
>
> Diffs
> -----
>
> src/collection/entryfilter.h 8eacf188d0d549c535efc55c22102d8a6aa88c62
> src/collection/entryfilter.cpp a6a2efaf806e82406d07ca2294987f4a637bc719
>
> Diff: https://git.reviewboard.kde.org/r/127156/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hartmut Riesenbeck
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160309/556fd826/attachment-0001.html>
More information about the kde-edu
mailing list